Fix configuration change crash with PdfNavigatorFragment
#398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickael-menu
commented
Sep 26, 2023
|
|
||
| override fun createDocumentFragmentFactory( | ||
| input: PdfDocumentFragmentInput<PdfiumDocumentFragment.Listener, PdfiumSettings> | ||
| ): SingleFragmentFactory<PdfiumDocumentFragment> = |
There was a problem hiding this comment.
We return a SingleFragmentFactory which is a custom implementation of FragmentFactory able to instantiate a new instance without knowing the class of the fragment.
mickael-menu
commented
Sep 26, 2023
| // We don't support fragment restoration for the PdfFragment, as we want to recreate a fresh | ||
| // instance in [reset]. To prevent restoring (and crashing) the PdfFragment without a | ||
| // document source, we remove it from the fragment manager. | ||
| (childFragmentManager.findFragmentByTag(pdfFragmentTag) as? PdfFragment) |
There was a problem hiding this comment.
Thankfully, PSPDFKit's PdfFragment will crash when creating its view and not when creating the fragment, so we have time to remove it from the fragment manager.
mickael-menu
commented
Sep 26, 2023
| @@ -9,17 +8,17 @@ public interface InputListener { | |||
| * Called when the user tapped the content, but nothing handled the event internally (eg. | |||
| * by following an internal link). | |||
| */ | |||
| public fun onTap(navigator: VisualNavigator, event: TapEvent): Boolean = false | |||
There was a problem hiding this comment.
I simplified InputListener to not depend on a Navigator instance. This way it could be forwarded to a lower level component, such as a PdfDocumentFragment.
mickael-menu
commented
Sep 26, 2023
readium/navigator/src/main/java/org/readium/r2/navigator/pdf/PdfNavigatorFactory.kt
Outdated
Show resolved
Hide resolved
qnga
reviewed
Oct 2, 2023
.../pdfium/pdfium-document/src/main/java/org/readium/adapters/pdfium/document/PdfiumDocument.kt
Outdated
Show resolved
Hide resolved
readium/navigator/src/main/java/org/readium/r2/navigator/pdf/PdfNavigatorFactory.kt
Outdated
Show resolved
Hide resolved
… into fix/pdf-fragments
qnga
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PdfDocumentFactorynow returns aResourceTry<PdfDocument>instead of throwing an exception in case of an error.PdfEngineProvidernow provides aFragmentFactoryfor thePdfDocumentFragment.PdfNavigatorFragmentis the source of truth for the current page and settings. When restoring the fragment, thePdfDocumentFragmentis recreated from the last known page index and settings stored in the view model. This is to simplify the implementations ofPdfDocumentFragment, which don't need to save and restore any state.