-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Scannable#name()
and related logic
#3901
Open
Stephan202
wants to merge
8
commits into
reactor:main
Choose a base branch
from
PicnicSupermarket:sschroevers/traces-performance-improvement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Optimize Scannable#name()
and related logic
#3901
Stephan202
wants to merge
8
commits into
reactor:main
from
PicnicSupermarket:sschroevers/traces-performance-improvement
+220
−68
Commits on Nov 26, 2024
-
Optimize
Traces#extractOperatorAssemblyInformationParts
This logic may be executed many times, e.g. if a hot code path uses `{Mono,Flux}#log` or Micrometer instrumentation. The added benchmark shows that for large stack traces the new implementation is several orders of magnitude more efficient in terms of compute and memory resource utilization. While there, improve two existing benchmarks by utilizing the black hole to which benchmark method return values are implicitly sent.
Configuration menu - View commit details
-
Copy full SHA for 518d059 - Browse repository at this point
Copy the full SHA 518d059View commit details -
Defer
Scannable#name()
fallback logic(cherry picked from commit 009ec89)
Configuration menu - View commit details
-
Copy full SHA for a67e27c - Browse repository at this point
Copy the full SHA a67e27cView commit details
Commits on Nov 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c3e519a - Browse repository at this point
Copy the full SHA c3e519aView commit details
Commits on Nov 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6f7d079 - Browse repository at this point
Copy the full SHA 6f7d079View commit details
Commits on Nov 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7c8ce7b - Browse repository at this point
Copy the full SHA 7c8ce7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02fa17e - Browse repository at this point
Copy the full SHA 02fa17eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36b3845 - Browse repository at this point
Copy the full SHA 36b3845View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cef75f - Browse repository at this point
Copy the full SHA 9cef75fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.