Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Introducing Hooks #18

Merged
merged 6 commits into from
Mar 1, 2019
Merged

Translate Introducing Hooks #18

merged 6 commits into from
Mar 1, 2019

Conversation

itayyehezkel
Copy link
Collaborator

No description provided.

@tesseralis tesseralis mentioned this pull request Feb 26, 2019
Closed
88 tasks
galtalmor
galtalmor requested changes Feb 27, 2019
View reviewed changes
Copy link
Collaborator

@galtalmor galtalmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments and fix line change issues in order for reviewers to be able to keep reviewing after line 45 (see the last comment). Thanks!

content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
galtalmor
galtalmor requested changes Feb 28, 2019
View reviewed changes
Copy link
Collaborator

@galtalmor galtalmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be so nitpicky, but there were some critical readability issues that I had to point out and then it started to stack up. Sorry if I'm being annoying and thanks for the contribution!

content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
@itayyehezkel itayyehezkel merged commit dbb63b9 into reactjs:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muli muli muli left review comments

@galtalmor galtalmor galtalmor requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itayyehezkel @galtalmor @muli