enhance: Add garbage collection based on expiry time #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c94c83f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: c94c83f | Previous: af07e7a | Ratio |
|---|---|---|---|
normalizeLong |
499 ops/sec (±0.80%) |
507 ops/sec (±0.26%) |
1.02 |
infer All |
8849 ops/sec (±1.38%) |
8891 ops/sec (±1.36%) |
1.00 |
denormalizeLong |
234 ops/sec (±3.01%) |
266 ops/sec (±2.47%) |
1.14 |
denormalizeLong donotcache |
871 ops/sec (±0.38%) |
837 ops/sec (±0.29%) |
0.96 |
denormalizeShort donotcache 500x |
1356 ops/sec (±0.30%) |
1333 ops/sec (±0.29%) |
0.98 |
denormalizeShort 500x |
764 ops/sec (±2.08%) |
770 ops/sec (±2.37%) |
1.01 |
denormalizeShort 500x withCache |
4738 ops/sec (±0.54%) |
4820 ops/sec (±0.88%) |
1.02 |
denormalizeLong with mixin Entity |
245 ops/sec (±1.86%) |
251 ops/sec (±1.90%) |
1.02 |
denormalizeLong withCache |
6868 ops/sec (±0.31%) |
7533 ops/sec (±0.27%) |
1.10 |
denormalizeLong All withCache |
6218 ops/sec (±0.40%) |
6399 ops/sec (±0.21%) |
1.03 |
denormalizeLong Query-sorted withCache |
5972 ops/sec (±0.80%) |
6328 ops/sec (±0.40%) |
1.06 |
denormalizeLongAndShort withEntityCacheOnly |
1562 ops/sec (±0.67%) |
1623 ops/sec (±0.43%) |
1.04 |
getResponse |
6162 ops/sec (±1.16%) |
6049 ops/sec (±1.40%) |
0.98 |
getResponse (null) |
4776617 ops/sec (±0.49%) |
5488573 ops/sec (±0.42%) |
1.15 |
getResponse (clear cache) |
239 ops/sec (±2.05%) |
248 ops/sec (±1.93%) |
1.04 |
getSmallResponse |
2528 ops/sec (±0.21%) |
2710 ops/sec (±0.28%) |
1.07 |
getSmallInferredResponse |
1925 ops/sec (±0.87%) |
2051 ops/sec (±0.19%) |
1.07 |
getResponse Query-sorted |
6592 ops/sec (±0.41%) |
6376 ops/sec (±0.76%) |
0.97 |
getResponse Collection |
6353 ops/sec (±1.17%) |
7040 ops/sec (±1.31%) |
1.11 |
get Collection |
4996 ops/sec (±0.92%) |
6235 ops/sec (±0.43%) |
1.25 |
setLong |
506 ops/sec (±0.58%) |
494 ops/sec (±0.51%) |
0.98 |
setLongWithMerge |
192 ops/sec (±0.89%) |
195 ops/sec (±0.35%) |
1.02 |
setLongWithSimpleMerge |
205 ops/sec (±0.41%) |
205 ops/sec (±0.36%) |
1 |
setSmallResponse 500x |
906 ops/sec (±0.26%) |
890 ops/sec (±1.66%) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
ntucker
force-pushed
the
gc
branch
2 times, most recently
from
67752cc to
90e2adf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3343 +/- ##
==========================================
- Coverage 98.85% 98.77% -0.08%
==========================================
Files 132 138 +6
Lines 2274 2374 +100
Branches 466 484 +18
==========================================
+ Hits 2248 2345 +97
- Misses 13 15 +2
- Partials 13 14 +1 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Fix code scanning alert no. 81: Prototype-polluting assignment Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Revert "Fix code scanning alert no. 81: Prototype-polluting assignment" This reverts commit 848b4981b3c563c2bb0e5e7bcc47d39001bf083d.
ntucker
force-pushed
the
gc
branch
2 times, most recently
from
b5297c1 to
ae4add3
Compare
ntucker
force-pushed
the
gc
branch
4 times, most recently
from
358c9ec to
626738f
Compare
ntucker
force-pushed
the
gc
branch
4 times, most recently
from
61a0ffb to
43bccb5
Compare
ntucker
force-pushed
the
gc
branch
2 times, most recently
from
8ff9d0b to
8159758
Compare
ntucker
force-pushed
the
gc
branch
2 times, most recently
from
cbda856 to
bd56d4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3240
Motivation
Clean memory for long running applications
Solution
countRef()Open Questions