Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build JS distributables using local javascript #1243

Merged

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Nov 22, 2024

Description

It was kind of annoying that our Python wheels didn't utilize the latest JavaScript contained within this repo, requiring a "chain of NPM releases" prior to being able to do a Python release.

This change allows us to utilize local JavaScript for builds, rather than relying on NPM releases.

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@Archmonger Archmonger marked this pull request as ready for review November 22, 2024 08:50
@Archmonger Archmonger merged commit 7d47f4f into reactive-python:main Nov 22, 2024
17 checks passed
@Archmonger Archmonger deleted the use-local-pkg-for-js-builds branch November 22, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant