Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the CI #1233

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Fix the CI #1233

merged 5 commits into from
Oct 29, 2024

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Oct 28, 2024

Description

Hotfixes to ReactPy's CI just to get things going.

Realistically, we should rewrite everything to...

  • Drop NPM in favor of Bun
  • Drop flake8, isort, and black in favor of hatch fmt
  • Get rid of the monorepo structure

But that will be a significantly higher time commitment, so I'll leave that for another day.

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@Archmonger Archmonger marked this pull request as ready for review October 29, 2024 03:22
@Archmonger Archmonger merged commit f81c168 into reactive-python:main Oct 29, 2024
17 checks passed
@Archmonger Archmonger deleted the fix-monorepo-ci branch October 29, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant