Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PR workflow / workspace #1053
Update PR workflow / workspace #1053
Changes from 17 commits
604bc32
1919158
e2feeb3
1ce169d
3bd8b69
36bc76c
f9cb181
9b09ae3
3226177
ddeb91f
c63219d
a2e2418
ca61e74
2062f06
9eb7226
8e1fb38
cb940f0
afa0b5f
4a14d5c
ba4845a
88818f9
926211e
9e9664c
9d71dc6
0be93c7
30b09eb
cdadb0d
3996ae6
ae55330
200ae13
f6b6cd2
131fe0a
aac0dc2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we need to configure this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without customizing this, sometimes VS Code will try to use tabs instead of spaces depending on the file type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already the default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting
python.languageServer
andpython.liniting.enabled
allows for VS Code to warn the user if it's not installed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already the default except on VSCode insiders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep it off in anticipation of the insiders build coming to main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already the default if installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting
python.languageServer
andpython.liniting.enabled
allows for VS Code to warn the user if it's not installed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use all the defaults for Prettier. I also think it will auto detect project configuration by looking for one of the places it might be set: https://prettier.io/docs/en/configuration.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without
proseWrap
andendOfLine
, prettier will auto-format jinja templates in a way that breaks them.This file was deleted.