Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR workflow / workspace #1053

Merged
merged 33 commits into from
Mar 6, 2024
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
604bc32
Add VS Code config
Archmonger Jun 15, 2023
1919158
Change pull request template
Archmonger Jun 15, 2023
e2feeb3
remove isort
Archmonger Jun 15, 2023
1ce169d
add ruff
Archmonger Jun 15, 2023
3bd8b69
subtext
Archmonger Jun 15, 2023
36bc76c
update PR comments
Archmonger Jun 15, 2023
f9cb181
remove github projects link
Archmonger Jun 15, 2023
9b09ae3
Add s
Archmonger Jun 15, 2023
3226177
add more extensions
Archmonger Jun 16, 2023
ddeb91f
Merge remote-tracking branch 'upstream/main' into workspace-config
Archmonger Jun 20, 2023
c63219d
remove subjective extensions
Archmonger Jun 27, 2023
a2e2418
remove py-tpl
Archmonger Jun 27, 2023
ca61e74
set black as default formatter
Archmonger Jun 27, 2023
2062f06
Update .github/pull_request_template.md
Archmonger Jun 29, 2023
9eb7226
Merge branch 'main' into workspace-config
rmorshea Jul 2, 2023
8e1fb38
re-add vscode to gitignore
Archmonger Jul 4, 2023
cb940f0
Merge branch 'main' into workspace-config
Archmonger Jul 4, 2023
afa0b5f
Merge remote-tracking branch 'upstream/main' into workspace-config
Archmonger Jul 13, 2023
4a14d5c
Merge branch 'main' into workspace-config
rmorshea Jul 15, 2023
ba4845a
remove auto import completion
Archmonger Jul 16, 2023
88818f9
Update pull request template
Archmonger Jul 18, 2023
926211e
remove stuff
Archmonger Jul 18, 2023
9e9664c
sort json
Archmonger Jul 18, 2023
9d71dc6
Merge branch 'main' into workspace-config
Archmonger Jul 27, 2023
0be93c7
remove newly deprecated settings
Archmonger Aug 8, 2023
30b09eb
Merge branch 'workspace-config' of https://github.com/Archmonger/reac…
Archmonger Aug 8, 2023
cdadb0d
remove jinja associations
Archmonger Aug 10, 2023
3996ae6
Remove settings.json
Archmonger Jan 11, 2024
ae55330
Merge branch 'main' into workspace-config
Archmonger Jan 11, 2024
200ae13
Update pull request template
Archmonger Jan 11, 2024
f6b6cd2
Merge branch 'main' into workspace-config
Archmonger Mar 6, 2024
131fe0a
Misc cleanup
Archmonger Mar 6, 2024
aac0dc2
Merge branch 'workspace-config' of https://github.com/Archmonger/reac…
Archmonger Mar 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<sub>By submitting this pull request you agree that all contributions to this project are made under the MIT license.</sub>

## Issues
## Summary

<!-- Link the issues this change resolves, or describe them -->
<!-- Describe these changes -->

## Summary
## Issues

<!-- Describe how these changes resolve the aforementioned issues -->
<!-- Link the issues this change resolves (if any) -->

## Checklist

- [ ] Tests have been included for all bug fixes or added functionality.
- [ ] The `changelog.rst` has been updated with any significant changes.
- [ ] Tests have been included for all bug fixes or added functionality.
- [ ] The `changelog.rst` has been updated with any significant changes.

<sub>By submitting this pull request you agree that all contributions are made under this project's open source license(s).</sub>
12 changes: 12 additions & 0 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"recommendations": [
"wholroyd.jinja",
"esbenp.prettier-vscode",
"ms-python.vscode-pylance",
"ms-python.python",
"charliermarsh.ruff",
"dbaeumer.vscode-eslint",
"ms-python.black-formatter",
"ms-python.mypy-type-checker"
]
}
36 changes: 36 additions & 0 deletions .vscode/settings.json
Archmonger marked this conversation as resolved.
Show resolved Hide resolved
Archmonger marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
{
"editor.detectIndentation": false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we need to configure this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without customizing this, sometimes VS Code will try to use tabs instead of spaces depending on the file type.

"editor.formatOnSave": true,
"python.linting.enabled": true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already the default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting python.languageServer and python.liniting.enabled allows for VS Code to warn the user if it's not installed.

"python.linting.mypyEnabled": true,
Archmonger marked this conversation as resolved.
Show resolved Hide resolved
"python.analysis.typeCheckingMode": "off",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already the default except on VSCode insiders

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep it off in anticipation of the insiders build coming to main?

"python.languageServer": "Pylance",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already the default if installed

Copy link
Contributor Author

@Archmonger Archmonger Jul 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting python.languageServer and python.liniting.enabled allows for VS Code to warn the user if it's not installed.

"python.formatting.provider": "black",
"python.analysis.autoImportCompletions": true,
"git.autofetch": "all",
"prettier.tabWidth": 4,
"prettier.useTabs": true,
"prettier.endOfLine": "auto",
"prettier.proseWrap": "never",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use all the defaults for Prettier. I also think it will auto detect project configuration by looking for one of the places it might be set: https://prettier.io/docs/en/configuration.html

Copy link
Contributor Author

@Archmonger Archmonger Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without proseWrap and endOfLine, prettier will auto-format jinja templates in a way that breaks them.

"files.associations": {
"**/requirements/*.txt": "pip-requirements",
Archmonger marked this conversation as resolved.
Show resolved Hide resolved
"**/templates/**.html": "jinja",
"**/template/**.html": "jinja",
},
"[json, jsonc]": {
Archmonger marked this conversation as resolved.
Show resolved Hide resolved
"editor.defaultFormatter": "vscode.json-language-features"
},
"[javascript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[css]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[python]": {
"editor.defaultFormatter": "ms-python.black-formatter",
Archmonger marked this conversation as resolved.
Show resolved Hide resolved
"editor.codeActionsOnSave": {
"source.organizeImports": true
}
},
"files.insertFinalNewline": true
}
13 changes: 4 additions & 9 deletions docs/source/about/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,10 @@ Changelog

.. note::

The ReactPy team manages their short and long term plans with `GitHub Projects
<https://github.com/orgs/reactive-python/projects/1>`__. If you have questions about what
the team are working on, or have feedback on how issues should be prioritized, feel
free to :discussion-type:`open up a discussion <question>`.

All notable changes to this project will be recorded in this document. The style of
which is based on `Keep a Changelog <https://keepachangelog.com/>`__. The versioning
scheme for the project adheres to `Semantic Versioning <https://semver.org/>`__. For
more info, see the :ref:`Contributor Guide <Creating a Changelog Entry>`.
All notable changes to this project will be recorded in this document. The style of
which is based on `Keep a Changelog <https://keepachangelog.com/>`__. The versioning
scheme for the project adheres to `Semantic Versioning <https://semver.org/>`__. For
more info, see the :ref:`Contributor Guide <Creating a Changelog Entry>`.


.. INSTRUCTIONS FOR CHANGELOG CONTRIBUTORS
Expand Down
9 changes: 0 additions & 9 deletions requirements.txt

This file was deleted.