Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view_to_iframe component #188

Merged
merged 29 commits into from
Sep 25, 2023
Merged

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Sep 19, 2023

Description

  • The compatibility argument on reactpy_django.components.view_to_component is deprecated.
  • Using reactpy_django.components.view_to_component as a decorator is deprecated.
  • reactpy_django.utils.register_iframe function has been added.
  • reactpy_django.components.view_to_iframe component has been added
  • It is now recommended to call as_view() when using view_to_component or view_to_iframe with Class Based Views.
  • Thread sensitivity has been enabled in all locations where ORM queries are possible.

Checklist:

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request you agree that all contributions comply with this project's open source license(s).

@Archmonger Archmonger marked this pull request as ready for review September 24, 2023 13:03
@Archmonger Archmonger requested a review from a team as a code owner September 24, 2023 13:03
@Archmonger Archmonger merged commit 6f79c4c into reactive-python:main Sep 25, 2023
7 checks passed
@Archmonger Archmonger deleted the view-to-iframe branch September 25, 2023 06:39
ShaheedHaque pushed a commit to ShaheedHaque/reactpy-django that referenced this pull request Oct 9, 2023
-   The `compatibility` argument on `reactpy_django.components.view_to_component` is deprecated.
-   Using `reactpy_django.components.view_to_component` as a decorator is deprecated.
-   `reactpy_django.utils.register_iframe` function has been added.
-   `reactpy_django.components.view_to_iframe` component has been added
-   It is now recommended to call `as_view()` when using `view_to_component` or `view_to_iframe` with Class Based Views.
-   Thread sensitivity has been enabled in all locations where ORM queries are possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant