-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish release to Docker Hub #94
publish release to Docker Hub #94
Conversation
Please remove failed release from GitHub. Also please include release notes in releases. |
Is #93 can be fixed before this new release. |
@gengjiawen I'm not sure. Let's merge this and release a new version. I'll try to use a new version in RN CI, and see if we'll have same problem. |
I am pretty positive it will have same problem, since we use same method. |
But I guess we can merge this for a start. |
@gengjiawen I find that https://app.circleci.com/pipelines/github/facebook/react-native/6768/workflows/57a0fb98-4eaa-4b47-9eb9-45c9d26d2e27/jobs/172694 is failing from difference cause. Currently, I'm busy debugging my own code 😎 |
I guess we can revert it if it cause many issues. Thanks again for the job. |
But we should recommend to use version tag instead of latest, and it will prevent from breaking changes. |
@gengjiawen You must publish a release, not pre-release, to publish an image to Docker Hub. |
This is more like a common practice in docker image. like node:latest always point to new latest release.
Looks like the build still starts https://github.com/react-native-community/docker-android/runs/1314431356. I published a draft release mainly due to avd failure. If it doesn't work, I will start a normal release. Thanks for the heads up. |
Looks like still official release still is ignored. |
Tag version of a release will be used as docker image tag, and must start with v, for example v2020-10-26. Publish action won't run if tag ref doesn't start with v.
FYI, after some investigation I found that $GITHUB_REF cannot be used as tag, so I parsed out version from GITHUB_REF and used it as tag.
closes #86