Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish release to Docker Hub #94

Merged

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Oct 26, 2020

Tag version of a release will be used as docker image tag, and must start with v, for example v2020-10-26. Publish action won't run if tag ref doesn't start with v.

FYI, after some investigation I found that $GITHUB_REF cannot be used as tag, so I parsed out version from GITHUB_REF and used it as tag.

closes #86

@dulmandakh
Copy link
Contributor Author

Please remove failed release from GitHub. Also please include release notes in releases.

@gengjiawen
Copy link
Member

Is #93 can be fixed before this new release.

@dulmandakh
Copy link
Contributor Author

@gengjiawen I'm not sure. Let's merge this and release a new version. I'll try to use a new version in RN CI, and see if we'll have same problem.

@gengjiawen
Copy link
Member

@gengjiawen I'm not sure. Let's merge this and release a new version. I'll try to use a new version in RN CI, and see if we'll have same problem.

I am pretty positive it will have same problem, since we use same method.

@gengjiawen
Copy link
Member

But I guess we can merge this for a start.

@gengjiawen gengjiawen merged commit f4192b2 into react-native-community:master Oct 27, 2020
@dulmandakh dulmandakh deleted the publish-version branch October 27, 2020 11:42
@dulmandakh
Copy link
Contributor Author

@gengjiawen I find that https://app.circleci.com/pipelines/github/facebook/react-native/6768/workflows/57a0fb98-4eaa-4b47-9eb9-45c9d26d2e27/jobs/172694 is failing from difference cause. Currently, I'm busy debugging my own code 😎

@gengjiawen
Copy link
Member

I guess we can revert it if it cause many issues. Thanks again for the job.

@dulmandakh
Copy link
Contributor Author

But we should recommend to use version tag instead of latest, and it will prevent from breaking changes.

@dulmandakh
Copy link
Contributor Author

dulmandakh commented Oct 27, 2020

@gengjiawen You must publish a release, not pre-release, to publish an image to Docker Hub.

@gengjiawen
Copy link
Member

But we should recommend to use version tag instead of latest, and it will prevent from breaking changes.

This is more like a common practice in docker image. like node:latest always point to new latest release.

You must publish a release, not pre-release, to publish an image to Docker Hub.

Looks like the build still starts https://github.com/react-native-community/docker-android/runs/1314431356. I published a draft release mainly due to avd failure. If it doesn't work, I will start a normal release. Thanks for the heads up.

@gengjiawen
Copy link
Member

Looks like still official release still is ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release a new version
2 participants