Get only the first container on node to call command #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gonzalo thanks for feedback and your contribution! I haven't expected anyone would be interested ... I have to checkout the |
rdxmb
reviewed
Aug 8, 2019
| @@ -39,6 +39,11 @@ fi | |||
| if PAIR=$(dockernodeps $SERVICE) ; then | |||
| NODE=${PAIR%%:*} | |||
| CONTAINER=${PAIR#*:} | |||
| #this sequence takes the first container in case there are more of one in the node | |||
There was a problem hiding this comment.
PAIR=${PAIR%% *} would also fix that. Could you test that, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using your extremely useful helpers for a year (thanks!) and just found a small issue. When there are multiple replicas of the same service in the same node the command fails because it tries to invoke it with both container names and takes the second one as the parameter.
Example:
My proposal is to slice PAIR string to catch only the first container. I did it in a roughly way (despite it works) because I don't know too much about parameter expansion but probably it could be done in a more elegant way.