Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for php attributes, new loader #90

Merged
merged 6 commits into from
Sep 5, 2023
Merged

Added support for php attributes, new loader #90

merged 6 commits into from
Sep 5, 2023

Conversation

cergey-obr
Copy link

  1. Added a new loader for attributes
  2. Added attribute support for all annotations

@rdohms rdohms added this to the v5.0.0 milestone Sep 4, 2023
@rdohms
Copy link
Owner

rdohms commented Sep 4, 2023

Let's ignore the code style breakage. I'm bumping the project to a new version of the standard that hopefully fixes that, we can tackle it in another PR.

rdohms
rdohms approved these changes Sep 5, 2023
View reviewed changes
Copy link
Owner

@rdohms rdohms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, let me get the code style issues sorted and some updates and I'll put a release together.

@rdohms rdohms merged commit cb5123d into rdohms:master Sep 5, 2023
4 of 5 checks passed
@rdohms rdohms added the Feature New feature or request label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdohms rdohms rdohms approved these changes

Assignees
No one assigned
Labels
Feature New feature or request
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cergey-obr @rdohms