Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh#100: dsVideoPort: Add L1 and L2 Test cases for ALLM APIs #129

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

gh#100: dsVideoPort: Add L1 and L2 Test cases for ALLM APIs #129

wants to merge 3 commits into from
+463 −8

Conversation

bhanucbp
Copy link
Contributor

@bhanucbp bhanucbp commented Aug 9, 2024

Add L1 and L2 test cases for dsSetAllmEnabled and dsGetAllmEnabled

@bhanucbp bhanucbp self-assigned this Aug 9, 2024
@bhanucbp bhanucbp changed the title gh#100: Add L1 and L2 Test cases for ALLM APIs gh#100: dsVideoPort: Add L1 and L2 Test cases for ALLM APIs Aug 9, 2024
@bhanucbp bhanucbp force-pushed the feature/gh100_dsvideoport_allm_l1_l2 branch from 957213f to dcf1de2 Compare August 9, 2024 10:56
@bhanucbp bhanucbp linked an issue Aug 9, 2024 that may be closed by this pull request
L1 and L2 for ALLM updates - dsVideoPort. #100
Open
@bhanucbp bhanucbp force-pushed the feature/gh100_dsvideoport_allm_l1_l2 branch 5 times, most recently from 739d7af to 7d9eb13 Compare August 9, 2024 14:32
@bhanucbp
gh#100: dsVideoPort: Add L1 and L2 Test cases for ALLM APIs
1d0ebe0 
Add L1 and L2 test cases for dsSetAllmEnabled and dsGetAllmEnabled
@bhanucbp bhanucbp force-pushed the feature/gh100_dsvideoport_allm_l1_l2 branch from 7d9eb13 to 1d0ebe0 Compare August 9, 2024 14:34
Anbukannadhasan
Anbukannadhasan reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@Anbukannadhasan Anbukannadhasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added review comments

src/test_l1_dsVideoPort.c Outdated
gTestID = 79;
UT_LOG("\n In %s [%02d%03d]\n", __FUNCTION__, gTestGroup, gTestID);

dsError_t status;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initialize with default values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/test_l1_dsVideoPort.c
UT_LOG("\n In %s [%02d%03d]\n", __FUNCTION__, gTestGroup, gTestID);

dsError_t status;
intptr_t handle = 0, valid_handle = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initialize with default values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/test_l1_dsVideoPort.c Outdated
gTestID = 81;
UT_LOG("\n In %s [%02d%03d]\n", __FUNCTION__, gTestGroup, gTestID);

dsError_t status;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initialize with default values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

hari22yuva
hari22yuva reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@hari22yuva hari22yuva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added review comments

docs/pages/ds-video-port_L2_Low-Level_TestSpecification.md Outdated
Step3 -->|dsERR_NONE|Step4[Call dsGetAllmEnabled API]
Step4 -->|dsERR_NONE|Step5[Compare ALLM Status]
Step5 -->|loop through | Step2
Step5 -- "dsERR_NONE" --> Fail6[Test Case Failed]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not dsERR_NONE is a failure case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/test_l1_dsVideoPort.c Outdated
*/
void test_l1_dsVideoPort_positive_dsGetAllmEnabled(void) {
gTestID = 79;
UT_LOG("\n In %s [%02d%03d]\n", __FUNCTION__, gTestGroup, gTestID);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you rebase the branch, UT_LOG is replaced with UT_LOG_INFO
for consistence use UT_LOG_INFO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/test_l1_dsVideoPort.c
UT_ASSERT_EQUAL(status, dsERR_NONE);
}
else {
UT_ASSERT_EQUAL(status, dsERR_INVALID_PARAM);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this -ve test case ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API is supported only for HDMI port

src/test_l1_dsVideoPort.c
UT_ASSERT_EQUAL(status, dsERR_INVALID_PARAM);
}
else if (gSourceType == 0) {
UT_ASSERT_EQUAL(status, dsERR_OPERATION_NOT_SUPPORTED);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here dsERR_INVALID_PARAM?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per the interface doc, for sink devices API returns dsERR_OPERATION_NOT_SUPPORTED

src/test_l1_dsVideoPort.c
UT_ASSERT_EQUAL(status, dsERR_NONE);
}
else {
UT_ASSERT_EQUAL(status, dsERR_INVALID_PARAM);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this -ve test case ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API is supported only for HDMI port. For other ports its returns invalid

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@bhanucbp bhanucbp force-pushed the feature/gh100_dsvideoport_allm_l1_l2 branch from 164a409 to 73f3132 Compare August 20, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anbukannadhasan Anbukannadhasan Anbukannadhasan left review comments

@hari22yuva hari22yuva hari22yuva left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@bhanucbp bhanucbp

Labels
L1 related issues L2 Work Element All L2 work elements
Projects
HAL Interface - Upgrades
Status: Under Review
Milestone
4.0.0 - HAL Updates - Addition_Deleti...
Development

Successfully merging this pull request may close these issues.

L1 and L2 for ALLM updates - dsVideoPort.
4 participants
@bhanucbp @CLAassistant @hari22yuva @Anbukannadhasan