Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple provider app-passthrough: Result wrapped in result name field from schema #690

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pahearn73
Copy link
Contributor

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

Copy link

Code Coverage

Package Line Rate Health
core.main.src.processor 0%
core.launcher.src 0%
core.main.src.firebolt 3%
core.sdk.src.api.firebolt 77%
core.tdk.src.utils 0%
core.sdk.src.api 78%
core.main.src.bootstrap 0%
core.main.src.broker.thunder 22%
core.main.src.processor.storage 0%
core.main.src.state.cap 43%
core.sdk.src.extn.client 91%
device.thunder.src.bootstrap 0%
core.tdk.src.gateway 100%
device.thunder_ripple_sdk.src.client 74%
core.main.src.service.extn 40%
core.main.src.utils 26%
core.main.src.bootstrap.manifest 0%
core.sdk.src.extn.ffi 80%
core.main.src.broker 45%
core.sdk.src.framework 75%
core.main.src.bootstrap.extn 0%
core.sdk.src.api.gateway 72%
device.thunder_ripple_sdk.src 15%
device.thunder_ripple_sdk.src.processors.events 0%
device.thunder_ripple_sdk.src.bootstrap 0%
core.main.src 0%
core.sdk.src.utils 49%
core.main.src.state 23%
device.thunder.src 0%
core.sdk.src.api.observability 61%
openrpc_validator.src 74%
core.main.src.service.apps 47%
core.launcher.src.manager 7%
core.main.src.service 31%
core.main.src.firebolt.handlers 9%
core.sdk.src.api.manifest 91%
device.thunder_ripple_sdk.src.events 4%
core.sdk.src.api.distributor 84%
device.mock_device.src 52%
core.sdk.src.extn 83%
device.thunder_ripple_sdk.src.processors 9%
distributor.general.src 2%
core.sdk.src.api.device 77%
Summary 43% (18524 / 43268)

Minimum allowed line rate is 42%

}
} else {
error!(
error!(
"callback_app_event_emitter: Missing field in event data: field={}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also return Err<T> ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because we still want to return the event_handler and emit the event, but just log that the event data isn't what was expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants