Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add triple term names #53

Merged
merged 2 commits into from
Nov 19, 2024
Merged

feat: add triple term names #53

merged 2 commits into from
Nov 19, 2024

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented Nov 18, 2024

Adds a TripleTermName util type.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2e98c5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

tpluscode
tpluscode reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@tpluscode tpluscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only propose to change the docs header. Otherwise, looks good

query/common.d.ts Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jeswr @tpluscode
Update README.md
2e98c5d 
Co-authored-by: Tomasz Pluskiewicz <[email protected]>
@jeswr
Copy link
Contributor Author

jeswr commented Nov 19, 2024

I only propose to change the docs header. Otherwise, looks good

kewl - I don't have permission to merge, can you do that @tpluscode

@tpluscode tpluscode merged commit 115bb9c into rdfjs:master Nov 19, 2024
1 check passed
@tpluscode
Copy link
Contributor

There you go 🚀

@jeswr jeswr deleted the feat/tripletermname branch November 19, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpluscode tpluscode tpluscode approved these changes

@rubensworks rubensworks rubensworks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeswr @tpluscode @rubensworks