Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a files pattern that works for both npm and yarn #50

Closed
wants to merge 2 commits into from

Conversation

matthieubosquet
Copy link
Contributor

Fixes issue #49.

This changes the files pattern in package.json to something that both yarn and npm recognise.

Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: b51539c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rdfjs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthieubosquet
Copy link
Contributor Author

@tpluscode with this PR, the current release process should be able to successfully create a v1.1.1 granted we delete the currently existing:

  1. v1.1.1 tag
  2. v1.1.1 release

I would be more than happy to PR an update to the current action to test a GitHub release based publish flow if people are happy about it (maybe for a v1.1.2).

@tpluscode
Copy link
Contributor

tpluscode commented Sep 17, 2024

Well, turns out we cannot unpublished 1.1.1 without publishing a newer version first. There is no way back and we can try removing 1.1.1 from the registry later

@matthieubosquet
Copy link
Contributor Author

Superseded by #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants