Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined type in StopWatch::toHuman #273

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mwootten
Copy link

@mwootten mwootten commented Jul 3, 2023

Use unsigned long long instead of uint64_t in StopWatch::toHuman. Since isn't explicitly imported, using uint64_t breaks compilation with gcc 13.1.1; it was probably included by another header in the past. Additionally, this makes it consistent with the rest of the function.

Use `unsigned long long` instead of `uint64_t` in StopWatch::toHuman. Since <cstdint> isn't explicitly imported, using `uint64_t` breaks compilation with gcc 13.1.1; it was probably included by another header in the past. Additionally, this makes it consistent with the rest of the function.
@kamahen
Copy link

kamahen commented Oct 30, 2023

uint64_t is defined by doing:
#include #include <cstdint> in StopWatch.hpp and changing unsigned long long to uint64_t in both StopWatch.hpp and StopWatch.cpp.

There are quite a few other places where unsigned long long is used ... the exact definition of this is platform-dependent, so uint64_t is probably better.

Other files use uint64_t without <cstdint>, so probably something one of the other <c...> includes works instead.

@kamahen
Copy link

kamahen commented Oct 30, 2023

This compiles with gcc-12.2.0 (but with lots of warnings; gcc-13.2.0 also has lots of warnings).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants