Update Meshing.jl examples for v0.7 #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrolho
reviewed
Nov 21, 2024
ferrolho
reviewed
Nov 21, 2024
ferrolho
reviewed
Nov 21, 2024
|
Thank you for working on this and fixing the example! I've left a few nitpick suggestions. I'll try and have a look at why GeometryBasics v0.5 is not working later. |
…nimum version required by the latest Meshing.jl version
ferrolho
force-pushed
the
Update-Meshing.jl-examples-for-v0.7
branch
from
08a90f2 to
0a00fc8
Compare
Co-authored-by: Henrique Ferrolho <[email protected]>
Co-authored-by: Henrique Ferrolho <[email protected]>
Co-authored-by: Henrique Ferrolho <[email protected]>
|
As promised, changes for supporting GeometryBasics v0.5 are proposed in #261. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the examples to work with the new version of Meshing.
I also had to remove the compat for GeometryBasics 0.5, because MeshCat failed to precompile.
Ref: JuliaGeometry/Meshing.jl#99