Skip to content

Commit

Permalink
Tests: use matrix to set sqlite config for syntax and doc tests
Browse files Browse the repository at this point in the history
Instead of doing the same thing in test.sh.
  • Loading branch information
Radu Carpa committed Oct 12, 2023
1 parent 8d065cb commit 3b14b16
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 8 deletions.
2 changes: 1 addition & 1 deletion etc/docker/dev/rucio_entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if [ -z "$RUCIO_HOME" ]; then
RUCIO_HOME=/opt/rucio
fi

mkdir -p $RUCIO_HOME
mkdir -p "$RUCIO_HOME"

generate_rucio_cfg(){
local override=$1
Expand Down
2 changes: 0 additions & 2 deletions etc/docker/test/extra/rucio_syntax.cfg

This file was deleted.

4 changes: 4 additions & 0 deletions etc/docker/test/matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,12 @@ suites:
- id: syntax
SYNTAX_REPORT: 1
RUN_HTTPD: false
RDBMS:
- sqlite
- id: docs
RUN_HTTPD: false
RDBMS:
- sqlite
- id: client_syntax
RUN_HTTPD: false
- id: client
Expand Down
4 changes: 4 additions & 0 deletions etc/docker/test/matrix_nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,12 @@ suites:
- id: syntax
SYNTAX_REPORT: 1
RUN_HTTPD: false
RDBMS:
- sqlite
- id: docs
RUN_HTTPD: false
RDBMS:
- sqlite
- id: client_syntax
RUN_HTTPD: false
- id: client
Expand Down
1 change: 1 addition & 0 deletions tools/merge_rucio_configs.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ def merge_configs(source_file_paths, dest_file_path, use_env=True, logger=loggin
logger(logging.INFO, "Merged {} configuration values from ENV".format(config_len(env_config)))

if dest_file_path:
logger(logging.INFO, "Writing {}".format(dest_file_path))
with open(dest_file_path, 'w') as dest_file:
parser.write(dest_file)
else:
Expand Down
5 changes: 0 additions & 5 deletions tools/test/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,6 @@ if [ "$SUITE" == "client" ] || [ "$SUITE" == "client_syntax" ]; then
cd $SOURCE_PATH
cp etc/docker/test/extra/rucio_client.cfg etc/rucio.cfg

elif [ "$SUITE" == "syntax" ] || [ "$SUITE" == "docs" ]; then
python3 $SOURCE_PATH/tools/merge_rucio_configs.py --use-env \
-s "$CFG_PATH"/rucio_autotests_common.cfg "$CFG_PATH"/rucio_syntax.cfg \
-d "$SOURCE_PATH"/etc/rucio.cfg

elif [ "$SUITE" == "votest" ]; then
VOTEST_HELPER=$RUCIO_HOME/tools/test/votest_helper.py
VOTEST_CONFIG_FILE=$RUCIO_HOME/etc/docker/test/matrix_policy_package_tests.yml
Expand Down

0 comments on commit 3b14b16

Please sign in to comment.