Fix current_state check in ImplementationWrapper._pre_transition_checks #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue when upgrading to Django 3.2, probably because of the memory isolation of
setUpTestDataobjects.The issue was that I had a
StateWrapperinstead of aStateobject during_pre_transition_checks, which caused an error even if I had the correct state for the transition.Another issuer was that
Stateinstance were not considered equal, probably because they were copied.The fixes I did are to compare
Stateby name, and to get theStateinstance inside theStateWrapperif we need to.Thanks for reviewing this PR 👍 .