This repository has been archived by the owner on Jul 28, 2021. It is now read-only.
Make ActiveRecord queries thread-safe #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgomes
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a threaded HTTP server like Puma, calling
Model.establish_connectionis dangerous. There is a chance the ActiveRecord connection is swapped by Casino itself and you'll get aTable doesn't existerror. In a really bad case though, Casino and the database we are connecting to may have auserstable of the same name which could result in incorrect data being accessed.This PR rewrites the connection to instead rely on a
ConnectionPoolwhich is thread-safe. Additionally it no longer requires a class to be meta-programmed and called -- it now just runs the SQL query directly.I will work on getting the tests to pass.