Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create CallbackSpinner thread in TaskRequestRosApi to avoid manual spinning in scenarios #57

Open
rayvburn opened this issue Aug 1, 2022 · 0 comments · May be fixed by #60
Open

create CallbackSpinner thread in TaskRequestRosApi to avoid manual spinning in scenarios #57

rayvburn opened this issue Aug 1, 2022 · 0 comments · May be fixed by #60
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rayvburn
Copy link
Owner

rayvburn commented Aug 1, 2022

Header:

/// Thread that provides callbacks to be processed (otherwise task requests won't be recognized by ActionServer)
std::thread callback_spinner_;

Source (ctor):

	callback_spinner_ = std::thread([this]() {
		// single-threaded spinning
		ros::spin();
	});

It does not compile ATM:

  • ROS Melodic,
  • gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
@rayvburn rayvburn added enhancement New feature or request help wanted Extra attention is needed labels Aug 1, 2022
rayvburn added a commit that referenced this issue Oct 3, 2023
]

- note: also got rid of `<functional>` from .cpp includes (locally only)
rayvburn added a commit that referenced this issue Oct 3, 2023
…execution performed in a separate thread [#29, #57]
@rayvburn rayvburn linked a pull request Oct 3, 2023 that will close this issue
rayvburn added a commit that referenced this issue Oct 3, 2023
]

- note: also got rid of `<functional>` from .cpp includes (locally only)
rayvburn added a commit that referenced this issue Oct 3, 2023
…execution performed in a separate thread [#29, #57]
rayvburn added a commit that referenced this issue Oct 11, 2023
]

- note: also got rid of `<functional>` from .cpp includes (locally only)
rayvburn added a commit that referenced this issue Oct 11, 2023
…execution performed in a separate thread [#29, #57]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant