Get rid of #[repr(C)] attribute on types

Callers are expected to copy the bytes into our structures before converting the pixels, and back out of our structures afterwards. Signed-off-by: Christopher N. Hesse <[email protected]>
raymanfx · Oct 29, 2023 · 27195c6 · 27195c6
1 parent cda22d3
commit 27195c6
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 5 deletions.
diff --git a/ffimage-yuv/src/lib.rs b/ffimage-yuv/src/lib.rs
@@ -1,2 +1,4 @@
+#![no_std]
+
 pub mod yuv;
 pub mod yuv422;
diff --git a/ffimage-yuv/src/yuv.rs b/ffimage-yuv/src/yuv.rs
@@ -9,7 +9,6 @@ use ffimage::color::rgb::*;
 use ffimage::Pixel;
 
 /// YUV pixel
-#[repr(C)]
 #[derive(Debug, Default, Clone, Copy, PartialEq, Eq)]
 pub struct Yuv<T, const Y: usize = 0, const U: usize = 1, const V: usize = 2>(pub [T; 3]);
 

diff --git a/ffimage-yuv/src/yuv422.rs b/ffimage-yuv/src/yuv422.rs
@@ -8,7 +8,6 @@ use crate::yuv::*;
 pub type Yuyv<T> = Yuv422<T, 0, 2, 1, 3>;
 pub type Uyvy<T> = Yuv422<T, 1, 3, 0, 2>;
 
-#[repr(C)]
 #[derive(Default, Debug, Copy, Clone, PartialEq, Eq)]
 pub struct Yuv422<
     T,

diff --git a/ffimage/src/color/gray.rs b/ffimage/src/color/gray.rs
@@ -5,7 +5,6 @@ use num::FromPrimitive;
 use crate::{color::rgb::Rgb, Pixel};
 
 /// Grayscale pixel
-#[repr(C)]
 #[derive(Debug, Default, Clone, Copy, PartialEq, Eq)]
 pub struct Gray<T>(pub [T; 1]);
 

diff --git a/ffimage/src/color/rgb.rs b/ffimage/src/color/rgb.rs
@@ -5,7 +5,6 @@ use num::FromPrimitive;
 use crate::Pixel;
 
 /// RGB pixel
-#[repr(C)]
 #[derive(Debug, Default, Clone, Copy, PartialEq, Eq)]
 pub struct Rgb<T, const R: usize = 0, const G: usize = 1, const B: usize = 2>(pub [T; 3]);
 
@@ -81,7 +80,6 @@ where
 }
 
 /// RGB pixel with alpha channel
-#[repr(C)]
 #[derive(Debug, Default, Clone, Copy, PartialEq, Eq)]
 pub struct Rgba<T, const R: usize = 0, const G: usize = 1, const B: usize = 2, const A: usize = 3>(
     pub [T; 4],