[core] [easy] Cleanup shared pointer for runtime env client #48975
+9
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
commented
Nov 27, 2024
| @@ -377,7 +377,7 @@ NodeManager::NodeManager( | |||
| dashboard_agent_manager_ = CreateDashboardAgentManager(self_node_id, config); | |||
| runtime_env_agent_manager_ = CreateRuntimeEnvAgentManager(self_node_id, config); | |||
|
|
|||
| runtime_env_agent_client_ = RuntimeEnvAgentClient::Create( | |||
There was a problem hiding this comment.
Not used elsewhere, ownership directly transferred to worker pool.
dentiny
force-pushed
the
hjiang/cleanup-runtime-env-client-shared
branch
from
168defa
to
f43c53e
Compare
Signed-off-by: hjiang <[email protected]>
dentiny
force-pushed
the
hjiang/cleanup-runtime-env-client-shared
branch
from
f43c53e
to
33187a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared pointer is wide-spread our codebase, which makes ownership justification and tracing hard.
To make things worse, new code has to confirm the same interface, which means more shared pointer.
Would like to spend some time to cleanup, start with something simple.