[core] remove PythonGcsClient as well as Python gRPC stubs to GCS. #48964
+39
−1,442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruiyang Wang <[email protected]>
jjyao
reviewed
Nov 27, 2024
| GCS_AIO_CLIENT_DEFAULT_THREAD_COUNT = env_integer( | ||
| "GCS_AIO_CLIENT_DEFAULT_THREAD_COUNT", 5 | ||
| ) | ||
| from ray._raylet import NewGcsClient |
There was a problem hiding this comment.
Yeah problem is we have NewGcsClient the binding and the GcsClient the one with call frequency counter. Not sure about the naming here...
There was a problem hiding this comment.
Got it.
Should it be GcsClient, GcsSyncClient and GcsAsyncClient?
jjyao
reviewed
Nov 28, 2024
Comment on lines
+13
to
+15
| Historical note: there was a `ray::gcs::PythonGcsClient` C++ binding which has only | ||
| sync API and in Python we wrap it with ThreadPoolExecutor. It's been removed in | ||
| favor of `ray::gcs::GcsClient` which contains async API. |
| GCS_AIO_CLIENT_DEFAULT_THREAD_COUNT = env_integer( | ||
| "GCS_AIO_CLIENT_DEFAULT_THREAD_COUNT", 5 | ||
| ) | ||
| from ray._raylet import NewGcsClient |
There was a problem hiding this comment.
Got it.
Should it be GcsClient, GcsSyncClient and GcsAsyncClient?
jjyao
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the effort to add Async GcsClient binding to Python, we allow both old and new code paths to live for a while and now it seems to be pretty stable. We never received any issues from customers about the NewGcsClient. Hence we remove the old one.