Fix unexpected reader_type kwarg error #443
Merged
+25
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change always pops the
reader_type
keyword argument, regardless of whether the encoding is identity or not.Rationale
We have had jobs fail due to using Parquet content type and Gzip file encoding. This change fixes that bug.
Changes
reader_type
kwargImpact
All calls to
s3_file_to_table
will have thereader_type
kwarg automatically popped, unless the reader type is daft orpartial_file_download_params
are defined.Testing
Regression Risk
Low
Checklist
Unit tests covering the changes have been added
E2E testing has been performed
Additional Notes
Any additional information or context relevant to this PR.