Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compactor performance regression checks within Github Workflows #252

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Add compactor performance regression checks within Github Workflows #252

merged 2 commits into from
Nov 28, 2023

Conversation

rkenmi
Copy link
Member

@rkenmi rkenmi commented Nov 28, 2023

This PR adds performance regression checks for the compactor.

Examples:

pfaraone
pfaraone approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@pfaraone pfaraone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. One minor comment

@rkenmi rkenmi merged commit 1127e54 into main Nov 28, 2023
5 checks passed
@rkenmi rkenmi deleted the dev/compaction-benchmark-pytest-cicd branch November 28, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfaraone pfaraone pfaraone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkenmi @pfaraone