Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Arrow to arrow-one-mmap-file-on-b228489 #1

Closed
wants to merge 19 commits into from

Conversation

guoyuhong
Copy link

@guoyuhong guoyuhong requested a review from pcmoritz February 23, 2019 09:31
@guoyuhong guoyuhong changed the title Update Arrow to [arrow-one-mmap-file-on-b228489](https://github.com/r… Update Arrow to arrow-one-mmap-file-on-b228489 Feb 23, 2019
@pcmoritz
Copy link
Contributor

@guoyuhong Thanks for the patch! Now that ray-project/ray#3898 is merged, we can move forward with this.

Before we can merge it, however we first need to fix the problem https://issues.apache.org/jira/browse/ARROW-4491 that happens with newer versions of arrow. If you have spare capacity to look into this let me know! I can only get to it at the end of the week I think, as I'm currently busy with ray-project/ray#4129, which I'm prioritizing to make sure we can exit the stage where we have to support both CMake and Bazel as soon as possible.

@guoyuhong
Copy link
Author

@pcmoritz Thanks for the information. I'm not quite understand what the Arrow JIRA issue is about. If I have time in the next several days, I will take a look at that issue.

@guoyuhong
Copy link
Author

@pcmoritz I have merged apache/arrow#3758 . Is that the correct solution?

@pcmoritz
Copy link
Contributor

Thanks, yes that is working now! Great :)

This PR is now integrated into the master of this repo too!

@pcmoritz pcmoritz closed this Feb 27, 2019
@guoyuhong guoyuhong deleted the updateArrow branch February 28, 2019 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants