Add safelist for object unserialization #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue (#46) was raised that describes an issue with not being able to store any kind of object in settings, since they will be unserialized to an object like
__PHP_Incomplete_Class(...). While the defaultValueSerializercan be overridden so that any objects can be unserialized properly, it may not always be desirable to create a custom class implementation of your own.This PR adds a
unserialize_safelistconfiguration option to allow you to specify which classes should be allowed to be unserialized. By default, we'll allow carbon date objects to be unserialized, but you are free to add more to the config.