Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash programmable completion for vcgencmd #700

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rgm3
Copy link

@rgm3 rgm3 commented Jul 9, 2021

Package the vcgencmd-completion.bash file as /usr/share/bash-completion/completions/vcgencmd to install.
The integration tests don't need to be shipped, but may help maintenance when updating the completion for future changes.

@rgm3
Copy link
Author

rgm3 commented Jul 9, 2021

The CMakeLists.txt file may want:

install(FILES vcgencmd-completion.bash DESTINATION bash-completion/completions/vcgencmd)

But I'm not sure. I'd be happy to update the PR if that seems correct.

@popcornmix
Copy link
Contributor

This seems useful.
@XECDesign how would this be best used in RPiOS? Would you install the file directly in /usr/share/bash-completion/?
Or just leave it to the user to install?

@XECDesign
Copy link
Contributor

I'd modify the packaging to install it appropriately.

The completion file should be renamed "vcgencmd" and
installed in /usr/share/bash-completion/completions/.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants