Swift support #132
Open
Swift support #132
+890
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: paulober <[email protected]>
Signed-off-by: paulober <[email protected]>
Signed-off-by: paulober <[email protected]>
Signed-off-by: paulober <[email protected]>
Signed-off-by: paulober <[email protected]>
Signed-off-by: paulober <[email protected]>
Signed-off-by: paulober <[email protected]>
Signed-off-by: paulober <[email protected]>
paulober
force-pushed
the
swift-support
branch
from
752c2ec to
8f57632
Compare
will-v-pi
reviewed
Dec 6, 2024
| @@ -1771,7 +1811,7 @@ export class NewProjectPanel { | |||
| </div> | |||
| </div>` | |||
| : `<h3 class="text-xl font-semibold text-gray-900 dark:text-white mb-4"> | |||
| Warning: Project Import Wizard may not work for all projects, and will often require manual correction after the import | |||
| Warning: Project Import Wizard may not work for all projects, and will often require manual correction after the import. Swift Projects aren't supported at the moment. | |||
There was a problem hiding this comment.
Maybe just say only C/C++ projects are supported, rather than swift isn't supported, as the import wizard also doesn't support Python?
Suggested change
| Warning: Project Import Wizard may not work for all projects, and will often require manual correction after the import. Swift Projects aren't supported at the moment. | |
| Warning: Project Import Wizard may not work for all projects, and will often require manual correction after the import. Only C/C++ Projects are supported at the moment. |
will-v-pi
reviewed
Dec 6, 2024
| const execAsync = promisify(exec); | ||
|
|
||
| export default async function checkSwiftRequirements(): Promise<boolean> { | ||
| return true; |
There was a problem hiding this comment.
Should this line be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift Support
This PR adds support for generating Swift projects.
Currently supported setups:
Setup steps are explained in the README.
TODO