convert windows path delimiter to posix (#2149) #2150
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
Dec 28, 2024
Comment on lines
+27
to
+28
| data = f"/{file.relative_to(input_dir).as_posix()}\x00" | ||
| comment = f"\"/{file.relative_to(input_dir).as_posix()}\" ({len(data)} chars)" |
There was a problem hiding this comment.
Might be worth doing a small refactoring here, so that the file.relative_to(input_dir).as_posix() is done just once (and assigned to a new variable) ?
There was a problem hiding this comment.
I agree that this minor refactor would make it a bit cleaner for sure.
There was a problem hiding this comment.
Perhaps separate refactoring from delimiter handling to make changes more consistent, since there are some format strings that could be refactored ? Perhaps add a new issue for refactoring ?
ndabas
reviewed
Dec 28, 2024
Comment on lines
+27
to
+28
| data = f"/{file.relative_to(input_dir).as_posix()}\x00" | ||
| comment = f"\"/{file.relative_to(input_dir).as_posix()}\" ({len(data)} chars)" |
There was a problem hiding this comment.
I agree that this minor refactor would make it a bit cleaner for sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2149
When generating lwip file system data convert windows directory separators by posix separators.
This is an issue when native directory during resource generation separator is "\" as on windows. Running toolchain from mingw64 python3 would also preserve "\" in resource name which would cause mismatch on resource lookup.
Fix should be portable with python 3.4 and up.