Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide slightly meaningless _start symbol for boot_stage2 to make LLVM lld happy #2080

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

kilograham
Copy link
Contributor

fixes #1813

@kilograham kilograham added this to the 2.1.0 milestone Nov 21, 2024
@kilograham kilograham changed the title provide slightly meaningless _start symbol for boot_stage2 to make LLVM ld happy provide slightly meaningless _start symbol for boot_stage2 to make LLVM lld happy Nov 21, 2024
@armandomontanez
Copy link
Contributor

ENTRY(_stage2_boot) should do the trick and might have slightly more clear intent.

@armandomontanez
Copy link
Contributor

Also side note, I'm not seeing any declarations of an .entry section in the codebase, am I missing something or is that something that could be cleaned up?

@kilograham
Copy link
Contributor Author

ENTRY(_stage2_boot) should do the trick and might have slightly more clear intent.

yeah, i thought about that, but there is no requirement to provide that symbol... we do always enter the image at the beginning

@kilograham
Copy link
Contributor Author

Also side note, I'm not seeing any declarations of an .entry section in the codebase, am I missing something or is that something that could be cleaned up?

indeed; i noticed that too, but didn't dig too deeply as to why it was there

@kilograham kilograham merged commit 90bfb53 into develop Nov 21, 2024
8 checks passed
@kilograham kilograham deleted the clang_lld_warning branch November 21, 2024 16:10
@kilograham
Copy link
Contributor Author

^ feel free to open separate issues/PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants