Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SparkFun ThingPlus RP2350 #2038

Merged

Conversation

sfe-SparkFro
Copy link
Contributor

Upcoming board from us!

Copy link
Contributor

@peterharperuk peterharperuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding the default cyw43 pins.

@lurch lurch self-requested a review November 13, 2024 19:27
@lurch
Copy link
Contributor

lurch commented Nov 13, 2024

LGTM, but I guess this might need a

// pico_cmake_set_default PICO_RP2350_A2_SUPPORTED = 1

line to satisfy the upcoming #2034 ? ping @will-v-pi

@will-v-pi
Copy link
Contributor

LGTM, but I guess this might need a

// pico_cmake_set_default PICO_RP2350_A2_SUPPORTED = 1

line to satisfy the upcoming #2034 ? ping @will-v-pi

Yeah, that’d be good, so I don’t have to rebase #2034 on top of this to add it

@sfe-SparkFro
Copy link
Contributor Author

Done!


// gpio pin for spi data out to the cyw43 chip
#ifndef CYW43_DEFAULT_PIN_WL_DATA_OUT
#define CYW43_DEFAULT_PIN_WL_DATA_OUT 24u
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just looking at this as part of the update for CYW43 support in arduino-pico on the RP2350 boards, so maybe I'm missing something, but are data_in, data_out, and host_wake all on pin 24?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Theoretically any GPIO pins can be used (see here: #1938 (comment)), but Raspberry Pi managed to cleverly connect all 3 pins of the radio to a single GPIO pin on the host processor. For reference, see the Pico W datasheet (schematic on page 23). This board uses the same connections with the same resistors to avoid contention.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the explanation!

@sfe-SparkFro
Copy link
Contributor Author

Hi there! Just curious to get an idea of what timeline to expect. Will this be able to make it into the v2.1.0 release? And is there an ETA of when that will release come out?

Thanks!

@peterharperuk peterharperuk added this to the 2.1.0 milestone Nov 18, 2024
@kilograham kilograham merged commit fe018f9 into raspberrypi:develop Nov 18, 2024
4 checks passed
@sfe-SparkFro sfe-SparkFro deleted the add_sparkfun_thingplus_rp2350 branch November 18, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants