More CYW43 config tweaks #2033
Merged
More CYW43 config tweaks #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
commented
Nov 11, 2024
peterharperuk
approved these changes
Nov 11, 2024
|
I suspect this may conflict with the int_frac change which i'd like to merge first |
Undoubtedly. Your PR is much chunkier than this one, so I'm happy to rebase this after #1926 has been merged 👍 |
- Re-synchronise the PICO_CMAKE_CONFIG: entries with the corresponding PICO_CONFIG: entries - Fix a silly typo I made in #2002 - Enhance config-extraction scripts to catch similar typos in future
lurch
force-pushed
the
move_cyw43_pico_configs
branch
from
d8d279d to
14c99f6
Compare
|
This has now been rebased on the latest |
peterharperuk
approved these changes
Nov 13, 2024
kilograham
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the previous #2002 (I spotted the typo, and ended up "fixing" a few other things in the process of fixing that!).