Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert hello_interp.c:times_table to µPython #58

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Convert hello_interp.c:times_table to µPython #58

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
642c203
Convert hello_interp.c:times_table to µPython
graeme-winter Jan 6, 2023
4a6ac01
Alias registers with sensible names
graeme-winter Jan 6, 2023
532a6b0
Typo
graeme-winter Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions interp/interp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
from machine import mem32

# initialise lane 0 on interp: set that we are using all 32 bits
mem32[0xD0000000 | 0xAC] = 0x1F << 10
Copy link
Contributor

@lurch lurch Jan 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not up to me whether this PR gets merged or not, but IMHO it'd be much easier to read if you had

SIO_BASE = 0xD0000000

INTERP0_ACCUM0 = 0x80
INTERP0_BASE0 = 0x88
INTERP0_POP_LANE0 = 0x94
INTERP0_CTRL_LANE0 = 0xAC

at the top of the file, and then this line could become:

mem32[SIO_BASE + INTERP0_CTRL_LANE0] = 0x1F << 10

(note that I've also changed the | to a +, which is probably more readable to most Python programmers?)

EDIT: I lifted those names directly from https://datasheets.raspberrypi.com/rp2040/rp2040-datasheet.pdf

Copy link
Author

@graeme-winter graeme-winter Jan 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent suggestion, thank you. Done.


# set up 9 x table example - write to accum[0] and base[0] registers
mem32[0xD0000000 | 0x80] = 0
mem32[0xD0000000 | 0x88] = 9

# read pop register 10 times
for j in range(10):
print(mem32[0xD0000000 | 0x94])