Deprecate use of the ScalerCropMaximum property #968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't know if there is a cleaner way to do this? |
naushir
force-pushed
the
next
branch
2 times, most recently
from
29cc7e8 to
e584831
Compare
This will be dropped by libcamera. Instead, use the maximum value of the ScalerCrop control, which stores an identical rectangle. Signed-off-by: Naushir Patuck <[email protected]>
davidplowman
reviewed
Mar 5, 2024
| @@ -92,7 +92,7 @@ def update_controls(): | |||
| global scaler_crop | |||
|
|
|||
| # Fix aspect ratio of the pan/zoom | |||
| full_img = picam2.camera_properties["ScalerCropMaximum"] | |||
There was a problem hiding this comment.
Actually (and sorry to be a pain...) could we do
_, full_img, _ = picam2.camera_controls['ScalerCrop']
I feel camera_ctrl_info should probably be made private at some point, and it would avoid people diving into the libcamera structures and having to do type conversions.
|
Replaced by #973, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be dropped by libcamera. Instead, use the maximum value of the ScalerCrop control, which stores an identical rectangle.