Timestamp capture #851
Merged
Timestamp capture #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that no pixel in the returned request started being exposed before the given timestamp. Any such requests are flushed out and not returned to the caller. The "flush" parameter may be an explicit timestamp (in nanoseconds, for example obtained from time.monotonic_ns()), or just True, meaning "now". Signed-off-by: David Plowman <[email protected]>
…timestamp Signed-off-by: David Plowman <[email protected]>
|
@naushir @will-v-pi Do we like this feature? I do get asked this kind of question from time to time, so I think it may be useful. I wonder a bit whether all the |
|
I can see this being useful. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to capture a request but where nothing was exposed before a given timestamp (which may be "now").
The second commit is an example/test for this functionality.