Timeout cancel #1069
Merged
Timeout cancel #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we do it only once, even when Picamera2.global_camera_info() is called before opening a camera. Signed-off-by: David Plowman <[email protected]>
Add a cancel_all_and_flush() function to clear out and cancel any jobs on the camera queue. This will allow the stop() function to operate when it would otherwise have got queued behind a job that had hung. Trying to access the result of any such cancelled job will result in a CancelledError. The wait parameter of all the "capture" functions is extended so that you can also supply an integer, being the time in seconds after which it will produce a TimeoutError if it has not finished. Signed-off-by: David Plowman <[email protected]>
davidplowman
force-pushed
the
timeout-cancel
branch
from
95937e2 to
9a988a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 commits
One is actually the timeout and cancel functionality.
The other is an improvement to the way we open the camera manager, just so as to produce less console chatter.