feat: update build to support tree-shaking #130
+19
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ex1st0r
reviewed
Feb 25, 2022
| filename: "rarible-sdk.js", | ||
| library: { | ||
| type: "module", | ||
| }, |
There was a problem hiding this comment.
wrong code: it duplicates code above
There was a problem hiding this comment.
Yes. Having umd and esm builds is common practice for libraries.
Umd is compatible with everything. Esm is not, but umd doesn't support tree shaking so adding an esm build is necessary.
Check out this article for more info: link
vanya2h
reviewed
Aug 22, 2022
| "module": "commonjs", | ||
| "target": "es5", | ||
| "module": "ESNEXT", | ||
| "target": "es2015", |
There was a problem hiding this comment.
this is breaking changes
be careful with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.