Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: removes unsupported apis #90

Merged
merged 1 commit into from
Oct 10, 2024
Merged

refactor!: removes unsupported apis #90

merged 1 commit into from
Oct 10, 2024

Conversation

YaswanthKumar-eng
Copy link
Contributor

This pr is about removing the not supported client api's for v2.

@YaswanthKumar-eng YaswanthKumar-eng requested review from a team as code owners September 19, 2024 07:34
@pallabpain pallabpain force-pushed the refactor/remove-io-broker-api-methods branch from c4ac4a2 to 45285d0 Compare September 19, 2024 09:19
@pallabpain pallabpain changed the title refactor!: remove unsupported apis refactor!: removes unsupported apis Sep 19, 2024
ankitrgadiya
ankitrgadiya requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@ankitrgadiya ankitrgadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, two suggestions:

  • Remove the Documentation pages for the Resources we removed.
  • Build CLI against it and run Automation Test Suite.

@smrutisenapati smrutisenapati force-pushed the refactor/remove-io-broker-api-methods branch 4 times, most recently from 71bd39f to 1d585d9 Compare September 27, 2024 12:39
@smrutisenapati
Copy link
Contributor

Once merged I will create a release PR, so that cli PR can be created.
Will post cli automation result soon

ankitrgadiya
ankitrgadiya reviewed Sep 27, 2024
View reviewed changes
CHANGELOG/CHANGELOG.md Outdated Show resolved Hide resolved
rapyuta_io/clients/project.py Show resolved Hide resolved
sdk_test/run_rio_sdk_test.py Outdated Show resolved Hide resolved
sdk_test/v2_client.py Show resolved Hide resolved
@ankitrgadiya
Copy link
Member

Let's also wait for the Automation results.

@smrutisenapati smrutisenapati force-pushed the refactor/remove-io-broker-api-methods branch from 1d585d9 to cf06ad5 Compare October 9, 2024 05:49
@ankitrgadiya ankitrgadiya force-pushed the refactor/remove-io-broker-api-methods branch from cf06ad5 to bc0ed4f Compare October 10, 2024 14:36
@ankitrgadiya ankitrgadiya force-pushed the refactor/remove-io-broker-api-methods branch from bc0ed4f to 5ec0e8c Compare October 10, 2024 14:38
@ankitrgadiya ankitrgadiya merged commit 18c9fe6 into devel Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitrgadiya ankitrgadiya ankitrgadiya approved these changes

@pallabpain pallabpain pallabpain approved these changes

@smrutisenapati smrutisenapati Awaiting requested review from smrutisenapati smrutisenapati is a code owner automatically assigned from rapyuta-robotics/io-first-reviewer

Assignees

@YaswanthKumar-eng YaswanthKumar-eng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YaswanthKumar-eng @smrutisenapati @ankitrgadiya @pallabpain