Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(device): allow custom config variables and labels during onboarding #80

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

rrkumarshikhar
Copy link
Contributor

… of creating the device

@rrkumarshikhar rrkumarshikhar requested review from a team as code owners June 16, 2024 21:04
@rrkumarshikhar rrkumarshikhar requested review from ankitrgadiya and RomilShah and removed request for a team June 16, 2024 21:04
@rrkumarshikhar rrkumarshikhar changed the base branch from master to devel June 16, 2024 21:04
@rrkumarshikhar rrkumarshikhar force-pushed the feat/device-custom-variables branch 2 times, most recently from fbea9b9 to 3348162 Compare June 17, 2024 03:34
@rrkumarshikhar rrkumarshikhar force-pushed the feat/device-custom-variables branch from 50ae1ee to 24da5e6 Compare June 17, 2024 04:44
Copy link
Member

@pallabpain pallabpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to the scope to feat:

@rrkumarshikhar

@rrkumarshikhar rrkumarshikhar changed the title chore: supports custom config-variables and custom labels at the time… feat: supports custom config-variables and custom labels at the time of onboarding the device on rapyuta-io Jun 17, 2024
@rrkumarshikhar rrkumarshikhar changed the title feat: supports custom config-variables and custom labels at the time of onboarding the device on rapyuta-io ✨feat: allow custom config variables and labels during device onboarding on rapyuta.io Jun 17, 2024
@rrkumarshikhar
Copy link
Contributor Author

Change to the scope to feat:

@rrkumarshikhar
updated the title

@pallabpain
Copy link
Member

Remove the emoji if you intend to squash and merge. It will fail the semantic release workflow.

@pallabpain pallabpain changed the title ✨feat: allow custom config variables and labels during device onboarding on rapyuta.io feat: allow custom config variables and labels during onboarding Jun 17, 2024
@pallabpain pallabpain changed the title feat: allow custom config variables and labels during onboarding feat(device): allow custom config variables and labels during onboarding Jun 17, 2024
@rrkumarshikhar rrkumarshikhar force-pushed the feat/device-custom-variables branch from 24da5e6 to 82ff44e Compare June 18, 2024 05:07
Copy link
Member

@ankitrgadiya ankitrgadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Check the unit test failing though.

@rrkumarshikhar rrkumarshikhar force-pushed the feat/device-custom-variables branch from 82ff44e to 4d03e99 Compare June 18, 2024 13:00
@ankitrgadiya ankitrgadiya merged commit 5834b1e into devel Jun 19, 2024
4 checks passed
rr-github-ci-user pushed a commit that referenced this pull request Jun 27, 2024
# [1.16.0](v1.15.1...v1.16.0) (2024-06-27)

### Features

* **device:** allow custom config variables and labels during creation ([#80](#80)) ([5834b1e](5834b1e))
@rr-github-ci-user
Copy link

🎉 This PR is included in version 1.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants