Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(paramserver): validates yaml or json data #77

Merged
merged 1 commit into from
May 17, 2024
Merged

fix(paramserver): validates yaml or json data #77

merged 1 commit into from
May 17, 2024

Conversation

pallabpain
Copy link
Member

@pallabpain pallabpain commented Mar 18, 2024 •
edited
Loading

Description

Validates the JSON or YAML data if the file is not uploaded as a blob before invoking the create_file API.

demo

@pallabpain pallabpain requested review from a team as code owners March 18, 2024 12:31
@pallabpain pallabpain requested review from ankitrgadiya and smrutisenapati and removed request for a team March 18, 2024 12:31
@pallabpain pallabpain force-pushed the fix/invalid-json-yaml branch 2 times, most recently from dac979d to a5632b2 Compare March 18, 2024 13:53
@pallabpain pallabpain self-assigned this Mar 18, 2024
@pallabpain pallabpain added the bug Something isn't working label Mar 18, 2024
@pallabpain pallabpain changed the base branch from master to devel March 18, 2024 13:57
@pallabpain pallabpain force-pushed the fix/invalid-json-yaml branch 2 times, most recently from 7236329 to 03efd6c Compare March 20, 2024 06:54
ankitrgadiya
ankitrgadiya reviewed Mar 20, 2024
View reviewed changes
Pipfile Show resolved Hide resolved
@pallabpain
fix(paramserver): validates yaml or json data
8013e9f 
Validates the JSON or YAML data if the file is not uploaded as a blob
before invoking the create_file API.

Wrike Ticket: https://www.wrike.com/open.htm?id=1315956250
@pallabpain pallabpain force-pushed the fix/invalid-json-yaml branch from 03efd6c to 8013e9f Compare March 21, 2024 06:30
@pallabpain pallabpain requested a review from ankitrgadiya May 15, 2024 05:49
ankitrgadiya
ankitrgadiya approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@ankitrgadiya ankitrgadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pallabpain pallabpain merged commit a543f71 into devel May 17, 2024
4 checks passed
rr-github-ci-user pushed a commit that referenced this pull request Jun 4, 2024
@semantic-release-bot
chore(release): 1.15.1 [skip ci]
8fcc9d6 
## [1.15.1](v1.15.0...v1.15.1) (2024-06-04)

### Bug Fixes

* **package:** removes parameter value validation ([df2f0dc](df2f0dc))
* **paramserver:** validates yaml or json data ([#77](#77)) ([a543f71](a543f71))
* **utils:** corrects exception handling in parse_json ([c16d229](c16d229))
@rr-github-ci-user
Copy link

🎉 This PR is included in version 1.15.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitrgadiya ankitrgadiya ankitrgadiya approved these changes

@smrutisenapati smrutisenapati Awaiting requested review from smrutisenapati smrutisenapati is a code owner automatically assigned from rapyuta-robotics/io-first-reviewer

Assignees

@pallabpain pallabpain

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pallabpain @rr-github-ci-user @ankitrgadiya