-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: implements async client #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guptadev21
requested review from
pallabpain and
smrutisenapati
and removed request for
a team
December 2, 2024 10:51
guptadev21
force-pushed
the
add-async-client
branch
from
December 2, 2024 11:04
bb7e987
to
ca0d358
Compare
pallabpain
requested changes
Dec 2, 2024
pallabpain
requested changes
Dec 4, 2024
Added some async tests and removed get_headers(kind of fixture) from tests as client fixture already writing values in config add new select rule in configuration
guptadev21
force-pushed
the
add-async-client
branch
from
December 5, 2024 07:50
0e91ade
to
97b734e
Compare
pallabpain
reviewed
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please update the code as suggested over Slack.
pallabpain
approved these changes
Dec 5, 2024
ankitrgadiya
requested changes
Dec 6, 2024
ankitrgadiya
pushed a commit
that referenced
this pull request
Dec 13, 2024
This commit implements the async client for the v2 APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and new features to the
rapyuta_io_sdk_v2
package, including enhancements to testing, configuration management, and the client interface. The most important changes include adding support for asynchronous operations, updating dependencies, and improving code quality with the Ruff linter.Asynchronous Support and Testing Enhancements:
AsyncClient
import inrapyuta_io_sdk_v2/__init__.py
to support asynchronous operations.walk_pages_async
function inrapyuta_io_sdk_v2/utils.py
to handle asynchronous pagination.tests/async_tests/test_configtree_async.py
to validate the functionality of asynchronous methods.Async Client Introduction:
rapyuta_io_sdk_v2/__init__.py
: ImportedAsyncClient
to enable async operations in the SDK.Method Updates:
rapyuta_io_sdk_v2/client.py
: Updated therefresh_token
method to include an optionalset_token
parameter and set the refreshed token in the configuration ifset_token
isTrue
. [1] [2]rapyuta_io_sdk_v2/client.py
: Added missing docstrings for several methods to improve code documentation. [1] [2] [3] [4]Test Coverage:
tests/async_tests/
: Added new async test casestests/utils/test_util.py
: Added a fixture for initializingAsyncClient
to support async test cases. [1] [2]Azure Task: Resolves AB#35883