Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: implements async client #5

Merged
merged 17 commits into from
Dec 12, 2024
Merged

✨ feat: implements async client #5

merged 17 commits into from
Dec 12, 2024

Conversation

guptadev21
Copy link
Contributor

@guptadev21 guptadev21 commented Dec 2, 2024

This pull request introduces several improvements and new features to the rapyuta_io_sdk_v2 package, including enhancements to testing, configuration management, and the client interface. The most important changes include adding support for asynchronous operations, updating dependencies, and improving code quality with the Ruff linter.

Asynchronous Support and Testing Enhancements:

  • Added AsyncClient import in rapyuta_io_sdk_v2/__init__.py to support asynchronous operations.
  • Introduced walk_pages_async function in rapyuta_io_sdk_v2/utils.py to handle asynchronous pagination.
  • Created new asynchronous test cases in tests/async_tests/test_configtree_async.py to validate the functionality of asynchronous methods.

Async Client Introduction:

Method Updates:

Test Coverage:

Azure Task: Resolves AB#35883

@guptadev21 guptadev21 requested review from a team as code owners December 2, 2024 10:51
@guptadev21 guptadev21 requested review from pallabpain and smrutisenapati and removed request for a team December 2, 2024 10:51
@guptadev21 guptadev21 self-assigned this Dec 2, 2024
@guptadev21 guptadev21 added the enhancement New feature or request label Dec 2, 2024
@pallabpain pallabpain changed the title ✨ Feat: Add Async Client ✨ feat: implements async client Dec 2, 2024
rapyuta_io_sdk_v2/client.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/client.py Outdated Show resolved Hide resolved
tests/utils/test_util.py Outdated Show resolved Hide resolved
Added some async tests and removed get_headers(kind of fixture) from tests as client fixture already writing values in config

add new select rule in configuration
Copy link
Member

@pallabpain pallabpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please update the code as suggested over Slack.

rapyuta_io_sdk_v2/async_client.py Show resolved Hide resolved
rapyuta_io_sdk_v2/async_client.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/async_client.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/async_client.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/async_client.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/async_client.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/async_client.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/async_client.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/async_client.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/async_client.py Outdated Show resolved Hide resolved
@pallabpain pallabpain merged commit f7ec584 into devel Dec 12, 2024
7 checks passed
ankitrgadiya pushed a commit that referenced this pull request Dec 13, 2024
This commit implements the async client for the v2 APIs.
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
# [0.1.0](v0.0.1...v0.1.0) (2024-12-13)

### Features

* add Client SDK for rapyuta.io v2 APIs ([9a459ce](9a459ce)), closes [AB#35882](https://github.com/AB/issues/35882)
* implements async client ([#5](#5)) ([2d74e3c](2d74e3c))
* implements initial sync for v2 APIs ([#3](#3)) ([8eefdae](8eefdae))
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
# [0.1.0](v0.0.1...v0.1.0) (2024-12-13)

### Features

* add Client SDK for rapyuta.io v2 APIs ([9a459ce](9a459ce)), closes [AB#35882](https://github.com/AB/issues/35882)
* implements async client ([#5](#5)) ([2d74e3c](2d74e3c))
* implements initial sync for v2 APIs ([#3](#3)) ([8eefdae](8eefdae))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants