Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implements initial sync for v2 APIs #3

Merged
merged 31 commits into from
Oct 28, 2024
Merged

feat: implements initial sync for v2 APIs #3

merged 31 commits into from
Oct 28, 2024

Conversation

guptadev21
Copy link
Contributor

@guptadev21 guptadev21 commented Oct 22, 2024 •
edited by azure-boards bot
Loading

Description

Testing

Checklist

  • Configuration class with necessary methods and class methods
    1. from_env: loads config from env
    2. from_file: loads config from file. default should be XDG_CONFIG_HOME on linux, and respective default on windows and mac like how click does it in the CLI.
  • Base sync client
  • Lint workflow
  • Conventional commits workflow
  • Publish to PyPi workflow
  • Semantic release workflow
  • CONTRIBUTING.md
  • README.md

Fixes AB#16658

@guptadev21 guptadev21 requested review from a team as code owners October 22, 2024 09:37
@guptadev21 guptadev21 requested review from amitsingh21 and smrutisenapati and removed request for a team October 22, 2024 09:37
@pallabpain pallabpain changed the base branch from init/v2-sdk to devel October 22, 2024 10:35
@pallabpain pallabpain changed the title Chore/refactor feat: implements initial sync and async client for v2 APIs Oct 22, 2024
pallabpain
pallabpain requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@pallabpain pallabpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: Copy the CONTRIBUTING.md from the CLI and modify it here accordingly.

.github/workflows/lint-check.yml Outdated Show resolved Hide resolved
.github/workflows/lint-check.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
pallabpain
pallabpain requested changes Oct 22, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/config.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/config.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/constants.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/constants.py Outdated Show resolved Hide resolved
pallabpain
pallabpain requested changes Oct 23, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
pallabpain
pallabpain requested changes Oct 23, 2024
View reviewed changes
.github/workflows/python-compatibility.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@guptadev21
chore: Update
b929c7e 
- Update pyproject.toml to add mock and pytest as dependencies
- Update rapyuta_io_sdk_v2/constants.py to include "mock_test" in NAMED_ENVIRONMENTS
@guptadev21
chore: add test files and list projects
997cb9e 
Update .gitignore to include the files main_test.py and test_config.json.
@guptadev21
chore: Update Python compatibility workflow and client.py
3896d9e
@pallabpain pallabpain added the enhancement New feature or request label Oct 24, 2024
pallabpain
pallabpain requested changes Oct 24, 2024
View reviewed changes
.github/workflows/release.yml Outdated Show resolved Hide resolved
pallabpain
pallabpain requested changes Oct 25, 2024
View reviewed changes
Copy link
Member

@pallabpain pallabpain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some TODOs

  • Add docstrings for public functions and classes.
  • Add type annotations everywhere.

rapyuta_io_sdk_v2/utils.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/utils.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/utils.py Show resolved Hide resolved
rapyuta_io_sdk_v2/constants.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/config.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/config.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/config.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/config.py Outdated Show resolved Hide resolved
rapyuta_io_sdk_v2/config.py Show resolved Hide resolved
@pallabpain pallabpain mentioned this pull request Oct 25, 2024
Closed
@pallabpain pallabpain changed the title feat: implements initial sync and async client for v2 APIs feat: implements initial sync for v2 APIs Oct 28, 2024
@pallabpain pallabpain merged commit 8eefdae into devel Oct 28, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@semantic-release-bot
chore(release): 0.1.0 [skip ci]
9ce32cd 
# [0.1.0](v0.0.1...v0.1.0) (2024-12-13)

### Features

* add Client SDK for rapyuta.io v2 APIs ([9a459ce](9a459ce)), closes [AB#35882](https://github.com/AB/issues/35882)
* implements async client ([#5](#5)) ([2d74e3c](2d74e3c))
* implements initial sync for v2 APIs ([#3](#3)) ([8eefdae](8eefdae))
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@semantic-release-bot
chore(release): 0.1.0 [skip ci]
b5e0a35 
# [0.1.0](v0.0.1...v0.1.0) (2024-12-13)

### Features

* add Client SDK for rapyuta.io v2 APIs ([9a459ce](9a459ce)), closes [AB#35882](https://github.com/AB/issues/35882)
* implements async client ([#5](#5)) ([2d74e3c](2d74e3c))
* implements initial sync for v2 APIs ([#3](#3)) ([8eefdae](8eefdae))
@rr-github-ci-user
Copy link

🎉 This PR is included in version 0.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pallabpain pallabpain pallabpain approved these changes

@amitsingh21 amitsingh21 Awaiting requested review from amitsingh21 amitsingh21 is a code owner automatically assigned from rapyuta-robotics/io-cli-owner

@smrutisenapati smrutisenapati Awaiting requested review from smrutisenapati smrutisenapati is a code owner automatically assigned from rapyuta-robotics/io-first-reviewer

Assignees

@guptadev21 guptadev21

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guptadev21 @rr-github-ci-user @pallabpain @YaswanthKumar-eng