feat(pydantic-settings): Initializes the pydantic settings for rio config-trees #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitsingh21
reviewed
Sep 23, 2024
| field: FieldInfo, | ||
| field_name: str, | ||
| ) -> Tuple[Any, str, bool]: | ||
| return "dummy_val", "dummy_val", False |
There was a problem hiding this comment.
why dummy_val ? we need to extract the field_name corresponding value from configtree fetched from upstream right ?
There was a problem hiding this comment.
@YaswanthKumar-eng ignore above comment, in the call method we are creating the dict which should be enough to get the complete dict, i think without overriding the get_field_value pydantic throws an error
pallabpain
requested changes
Oct 9, 2024
| dist/ | ||
| wheels/ | ||
| *.egg-info | ||
|
|
There was a problem hiding this comment.
todo: add .idea to this file.
| [project] | ||
| name = "rapyuta-io-sdk-v2" | ||
| version = "0.1.0" | ||
| description = "Version:2 for Rapyuta.io SDK" |
There was a problem hiding this comment.
Suggested change
| description = "Version:2 for Rapyuta.io SDK" | |
| description = "A Python SDK for rapyuta.io v2 APIs" |
|
|
||
| class AsyncClient(Client): | ||
|
|
||
| def __init__(self,config): |
There was a problem hiding this comment.
todo: Run a Reformat on the entire code in Pycharm. That should fix all the formatting.
Suggested change
| def __init__(self,config): | |
| def __init__(self, config): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr relates to initializes the pydantic settings for rapyuta_io config trees configurations for easy config management.