Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(device): supports host pid namespace item through package manifest #403

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

feat(device): supports host pid namespace item through package manifest #403

wants to merge 1 commit into from

Conversation

YaswanthKumar-eng
Copy link
Contributor

This PR modifies the host pid namespace item and this prop uses for schema validation.

@YaswanthKumar-eng YaswanthKumar-eng requested review from a team as code owners December 12, 2024 07:35
@github-actions GitHub Actions
Copy link

🤖 Pull Request Artifacts (#12291857466) 🎉

@YaswanthKumar-eng YaswanthKumar-eng changed the title feat(support-hostpid): supports host pid namespace item through package manifest feat(device): supports host pid namespace item through package manifest Dec 12, 2024
ankitrgadiya
ankitrgadiya approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@ankitrgadiya ankitrgadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, please update the commit message:

feat(package): supports hostPID for package

@ankitrgadiya
Copy link
Member

Please add the example in package samples as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitrgadiya ankitrgadiya ankitrgadiya approved these changes

@pallabpain pallabpain Awaiting requested review from pallabpain pallabpain is a code owner automatically assigned from rapyuta-robotics/io-cli-owner

@smrutisenapati smrutisenapati Awaiting requested review from smrutisenapati smrutisenapati is a code owner automatically assigned from rapyuta-robotics/io-first-reviewer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YaswanthKumar-eng @ankitrgadiya