Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Farsi translation #2100

Merged
merged 6 commits into from
Dec 1, 2024
Merged

Conversation

AmirMehrabi
Copy link
Contributor

Hello.
First of all, thank you for the great work. Really made my life easier.

Farsi-speaking user here. Just added the files for Farsi translation. I'm sure other Farsi speaking users will benefit.

Thank you again for the great work and please let me know what you think.

lrljoe and others added 6 commits November 21, 2024 21:16
## [v3.5.4] - 2024-11-21
### Bug Fixes
- Allow JSON and PHP type localisations by @lrljoe in rappasoft#2071
- Allow lazy loading of tables by @lrljoe in rappasoft#2072

### Testing
- RemoveConfigFileFromCoverage by @lrljoe in rappasoft#2080
- Test for ViewComponentColumn - Cannot return non-array attributes  by @lrljoe in rappasoft#2078
- BooleanFilter - Add Tests for Null in IsEmpty and Validate by @lrljoe in rappasoft#2077
- Add Attributes Check For ViewComponentColumn by @lrljoe in rappasoft#2076
- Add ViewComponentColumn label test  by @lrljoe in rappasoft#2075
- Add ColorColumnTests by @lrljoe in rappasoft#2074
@lrljoe
Copy link
Collaborator

lrljoe commented Nov 30, 2024

Hi @AmirMehrabi

Firstly - thank you very much for the contribution, localisations are really appreciated.

However - please issue your PR against the "development" branch.

I don't want to rebase your PR and cause you potential issues!

If you're on the official discord, ping me a message and I'll make sure you get the Translator tag, and I'll add you to the localisation contributors on the next release.

Thanks,

Joe.

@AmirMehrabi
Copy link
Contributor Author

Hi @AmirMehrabi - please issue your PR against the "development" branch.

I don't want to rebase your PR and cause you potential issues!

Thanks,

Joe.

Will do Joe.
Thank you very much

@AmirMehrabi AmirMehrabi changed the base branch from master to development November 30, 2024 22:35
@lrljoe lrljoe merged commit 3575b5c into rappasoft:development Dec 1, 2024
7 checks passed
lrljoe added a commit that referenced this pull request Dec 10, 2024
## [v3.5.8] - 2024-12-10
### New Features
- Set bulk action row button attributes by @lrljoe in #2117
- Add setFilterSlidedownWrapperAttributes and setFilterSlidedownRowAttributes by @lrljoe in #2120

### Bug Fixes
- Respect setDisplayPaginationDetailsDisabled for unpaginated tables by @lrljoe in #2119

### Localisation
- Added neccessary files for Farsi translation by @AmirMehrabi in #2100

### Testing
- Workflow Adjustments by @lrljoe in #2108
- Add extra Search Lazy Tests by @lrljoe in #2107
- Restore Missing Lazy Search Tests by @lrljoe in #2106
- Ignore WithEvents Coverage by @lrljoe in #2105
- Add missing tests for WithCustomisations by @lrljoe in #2104
- Add missing LivewireComponentFilterTest and BooleanFilterTest by @lrljoe in #2121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants