Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Typehinting from Blades #2097

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Nov 30, 2024

Whilst we want to typehint as far as possible, the following error occurred in a test environment:
image

Therefore this PR needs to be rolled back

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe changed the title Remove Typehinting Remove Typehinting from Blades Nov 30, 2024
@lrljoe lrljoe merged commit c7ea59b into rappasoft:development Nov 30, 2024
7 checks passed
@lrljoe lrljoe mentioned this pull request Dec 1, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant