-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development to Master #2084
Merged
Merged
Development to Master #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Unlock properties locked in error --------- Co-authored-by: lrljoe <[email protected]>
* Add additional dispatch * Add FilterApplied Event * Add Filter Event Dispatch Tests --------- Co-authored-by: lrljoe <[email protected]>
* Make ActionButtons An Optional Feature in Beta --------- Co-authored-by: lrljoe <[email protected]>
* Adjust Methods - useComputedProperties * Adjust ActionTest
* Add setIconLeft/setIconRight * Fix styling * Adjust Test * Adjust ActionTest --------- Co-authored-by: lrljoe <[email protected]>
* Adjust Action Button Icon Margin * Adjust ChangeLog
* Change Order of "Getting Started" section * Change to "UsersTable"
* Add a "Recommended" approach * Add blurb to Recommended
* Add displayActionsInToolbar and actionsPosition * Add docs and tests for setActionsInToolbar * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Add updatedPerPageTest * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Update phpdoc for boot * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Add test for No Columns * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Add Simple updatedSearch tests * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Add test for FilterApplied being dispatched * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Add test for ColumnsSelected Event dispatch * Apply Separate Tests --------- Co-authored-by: lrljoe <[email protected]>
* FixSetDefaultPerPage * Update getDefaultPerPage to respect getPerPageAccepted * Fix missing ) * Fix styling * Add test fix * Add final tests --------- Co-authored-by: lrljoe <[email protected]>
* Fix BooleanColumn unexpected truthy behaviour * Support previous iteration
* Add option to use json or PHP localisation files (interim fixes) * Fix styling * Typehinting Fixes * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Add ColorColumnTests * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Add Attributes Check For ViewComponentColumn * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* test_can_validate_null_boolean_filter_value * Fix styling * Add IsEmpty Test * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2084 +/- ##
============================================
+ Coverage 88.05% 88.15% +0.09%
- Complexity 1937 1945 +8
============================================
Files 184 186 +2
Lines 4430 4441 +11
============================================
+ Hits 3901 3915 +14
+ Misses 529 526 -3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
New Feature Submissions:
Changes to Core Features: