Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typehinting in blade components #2081

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

edwinvdpol
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

This will improve IDE autocompletion in blade files where applicable.

I would like to cleanup / structurize the blade files even more after this PR to make things more readable and consistent.

@lrljoe
Copy link
Collaborator

lrljoe commented Nov 21, 2024

Wow, lot of changes here! It'll probably be the weekend before I can review this properly.

Really appreciate the contribution!

@lrljoe lrljoe self-assigned this Nov 21, 2024
Copy link
Collaborator

@lrljoe lrljoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly reviewed & all okay so far, couple of files left for later this weekend, just the larger files that I need to skim over

@lrljoe
Copy link
Collaborator

lrljoe commented Nov 23, 2024

Just the big one (datatable.blade.php) to go, I'll look at that tomorrow, and get this merged in.

@lrljoe lrljoe merged commit de8d3bb into rappasoft:development Nov 28, 2024
7 checks passed
@lrljoe lrljoe mentioned this pull request Nov 28, 2024
@edwinvdpol edwinvdpol deleted the feature/optimize-blade branch November 28, 2024 00:52
@lrljoe
Copy link
Collaborator

lrljoe commented Nov 30, 2024

@edwinvdpol - while testing across different versions of PHP & Laravel, it seems that some supported versions presently misbehave with the typehinting in place:

image

This behaviour goes aware without the typehinting.

For the time-being, I'll be rolling back the typehinting in the blades

@edwinvdpol
Copy link
Contributor Author

Not sure what you mean, but allright. 😉
Can you specify which version of PHP and Laravel, and what goes wrong?

@lrljoe
Copy link
Collaborator

lrljoe commented Nov 30, 2024

Threw a screenshot on the last update, need to go through and validate the different environments it happens in to know for sure where it's coming from.

Effectively it's turning a chunk of the toolbar into HTML rather than blade (see screenshot)

Unsure if it's a cdn issue/specific config issue. at the mo, but backing it out resolved it.

Just need to ensure it doesn't break anyone's existing deployments.

I am definitely keen to get it added in tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants